Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move after login/logout/registration redirection to site settings #3845

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Move after login/logout/registration redirection to site settings #3845

merged 3 commits into from
Jul 9, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Jun 17, 2020

There are two issues with the current solution:

  1. I spent quite a while figuring out that the redirect settings were under Security and not Site Settings where I expected them together with other page settings.
  2. The current solution doesn't work for site groups as the PagePicker in the security module only allowed pages to be picked from the current portal but with a role setting from the master portal. This could never work.

This PR solves both issues at once. I've also added a message on the Security module so that people know where this went. In due course (DNN 10?) we can remove that message.

@donker donker added this to the 9.7.0 milestone Jun 17, 2020
donker and others added 2 commits June 17, 2020 14:31
@donker
Merge branch 'develop' into moveredirection
bdb655b
@bdukes
Merge branch 'develop' into moveredirection
4cd607f 
# Conflicts:
#	Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SecurityController.cs
#	Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
valadas
valadas approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right to me.

@bdukes bdukes merged commit 63aa99e into dnnsoftware:develop Jul 9, 2020
@donker donker deleted the moveredirection branch July 10, 2020 12:03
@daguiler daguiler mentioned this pull request Oct 28, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Area: AE > Dnn.PersonaBar.Extensions Area: AE > PersonaBar Ext > Security.Web Area: AE > PersonaBar Ext > SiteSettings.Web Type: Enhancement
Projects
None yet
Milestone
9.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@donker @bdukes @valadas