Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA12xx fixes - rearrange members #3882

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jun 30, 2020

Also adjusted some whitespace and moved a couple of classes into
separate files

Also adjusted some whitespace and moved a couple of classes into
separate files
@bdukes bdukes added this to the 9.7.0 milestone Jun 30, 2020
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually reviewed the first 150 files before the browser started bombing out. 😆

@mitchelsellers mitchelsellers merged commit 80b6b2c into dnnsoftware:develop Jul 1, 2020
@valadas
Copy link
Contributor

valadas commented Jul 2, 2020

Did'nt we discuss holding on these global auto-fixes after we finish with 9.6.2... We may have huge conflicts to resolve when we merge back release/9.6.2 into develop...

@valadas
Copy link
Contributor

valadas commented Jul 2, 2020

Ok, not too bad, only one file conflict, see #3888

I will try to resolve the conflict later today/tomorrow...

@bdukes bdukes deleted the style-cop-fixes branch July 24, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants