Fixes stylecop warnings on FolderManager.cs #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
bdukes
reviewed
Jul 13, 2020
bdukes
approved these changes
Jul 13, 2020
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
|
@bdukes I see multiple of your suggestions with the "commit suggestion" button greyed out, that means you did it? |
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
bdukes
reviewed
Jul 13, 2020
|
I haven't committed any of those changes, but maybe @mitchelsellers' commit included some of them. |
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
|
Ok, so I accepted the other suggestions, we just have to decide on the cast or adding an overload... |
|
I just pushed a change to add overloads (and deprecate the old overloads). |
|
Awesome @bdukes Love it. |
mitchelsellers
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@david-poindexter @mitchelsellers I fixed the stylcop issues on the FolderManager.cs class for fixing the search issues after with a cleaner PR that does not have huge changes.