Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List-Services command to Prompt #3932

Merged
merged 6 commits into from
Jul 27, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 24, 2020

This PR relies upon #3920.

Fixes #3931.

It doesn't need to implement IDnnStartup, it can just configure the
service provider and be done.  This also allows us to stop ignoring
other IDnnStartup instances in the DotNetNuke.Web project, were they to
be created later.
This ensures that it's called at the right time relative to all other DI
configuration.
@bdukes bdukes added this to the 9.7.0 milestone Jul 24, 2020
@bdukes bdukes changed the title Load DNN types first in DI startupList services command Add List-Services command to Prompt Jul 24, 2020
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, this is an EPIC developer feature for sure!

Per other commentary, I'm ok with this being in 9.6.3, but flag as a feature

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @bdukes - this is GREAT!

@david-poindexter david-poindexter merged commit 9fd6b58 into dnnsoftware:develop Jul 27, 2020
@bdukes bdukes deleted the list-services-command branch July 27, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new command to Prompt for debugging DI services
3 participants