Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset invalidation link on email change #3952

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

mikebigun
Copy link
Contributor

Summary

All details of this change are shared via private email.

@mikebigun
Copy link
Contributor Author

@zyhfish, I agree that setting is important but it doesn't fully protect the system. The user could change his email due to many reasons, including hacker attacks.. Email is a way we communicate, so after it is changed we must assure user the sensitive information we sent to his previous email address is not valid anymore.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

We should also review that this is a use once only token

@valadas valadas added this to the 9.7.1 milestone Aug 4, 2020
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@valadas valadas modified the milestones: 9.7.1, 9.7.0 Aug 4, 2020
@valadas valadas changed the base branch from develop to release/9.7.0 August 4, 2020 19:18
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@valadas valadas changed the title Reset link invalidation on email change Reset invalidation link on email change Aug 4, 2020
@valadas valadas merged commit c7c5e72 into dnnsoftware:release/9.7.0 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants