Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pencil icon moved to the right ... menu #4022

Merged

Conversation

tauqeer-haider
Copy link
Contributor

Fixes #3960

Summary

Pencil icon moved to the right ... menu. Only visible in Evoq and for unpublished pages.

Evoq rendering:
image

DNN Platform rendering:
image

@@ -123,7 +137,7 @@
.selection-arrow {
display: inline-block;
position: relative;
width: 90px;
width: 50px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valadas and others, this is the only bit that I see that might impact Platform only.

Long term, this Evoq only code shouldn't be here IMHO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we purposefully tried hard to gain as many pixels as possible for the very tight room we have in there. I would prefer if Evoq needs to shorten that, it is overriden in Evoq to not affect our efforts in this area for Platform.

@tauqeer-haider Would you be able to remove this change here and override it in Evoq css only ?

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting this to ONLY apply when the draft pencil is visible.

@david-poindexter david-poindexter added this to the 9.7.2 milestone Sep 7, 2020
@david-poindexter david-poindexter merged commit 79bb03a into dnnsoftware:develop Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pencil icon is not shown for non-published pages
4 participants