-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement clickable column headers on the users table #4032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Peter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works great. Maybe as a future improvement we could add some sort indicators...
I am feeling pretty save getting this into 9.7.2 anyone against ? |
I am good with it
…On Fri, Sep 4, 2020 at 4:41 PM Daniel Valadas ***@***.***> wrote:
I am feeling pretty save getting this into 9.7.2 anyone against ?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4032 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQIT7XXKMJ4KDJYLCYMFYLSEFUH7ANCNFSM4QSGNTMQ>
.
|
This PR allows the user to click on the three column headers to sort by them (DisplayName, Email and Joined Date). Clicking again will invert the sort order.