Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement clickable column headers on the users table #4032

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Implement clickable column headers on the users table #4032

merged 1 commit into from
Sep 5, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Sep 1, 2020

This PR allows the user to click on the three column headers to sort by them (DisplayName, Email and Joined Date). Clicking again will invert the sort order.

@donker donker added this to the 9.8.0 milestone Sep 1, 2020
mtrutledge
mtrutledge approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Peter

@mitchelsellers mitchelsellers modified the milestones: 9.8.0, 9.7.2 Sep 2, 2020
@mitchelsellers
Copy link
Contributor

@donker @valadas I see this tagged as version 9.8.x as this is a new feature. I think we could put in revision release, but adding the "On Hold" tag to prevent merging

@donker
Copy link
Contributor Author

donker commented Sep 2, 2020

@donker @valadas I see this tagged as version 9.8.x as this is a new feature. I think we could put in revision release, but adding the "On Hold" tag to prevent merging

I added it as I wanted to play it safe and have it on the list of new features for a minor release. But feel free to adjust.

valadas
valadas approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works great. Maybe as a future improvement we could add some sort indicators...

@valadas
Copy link
Contributor

valadas commented Sep 4, 2020

I am feeling pretty save getting this into 9.7.2 anyone against ?

@mtrutledge
Copy link
Contributor

mtrutledge commented Sep 4, 2020 via email

@valadas valadas merged commit f80d555 into dnnsoftware:develop Sep 5, 2020
@donker donker deleted the usersorting branch October 7, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrutledge mtrutledge mtrutledge approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Area: AE > PersonaBar Ext > Users.Web Type: Enhancement
Projects
None yet
Milestone
9.7.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donker @mitchelsellers @valadas @mtrutledge