Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with user management in portal groups #4041

Merged
merged 7 commits into from
Sep 3, 2020
Merged

Fixed an issue with user management in portal groups #4041

merged 7 commits into from
Sep 3, 2020

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Sep 3, 2020

  • Fixed an issue with user management in portal groups
  • Fixed many of the build warnings, there are a couple left about IPortalSettings vs PortalSettings which I did not fix because I think the correct solution would involve modifying other components so they can take IPortalSettings instead of PortalSettings and well, lack of time on that...

@valadas valadas added this to the 9.7.2 milestone Sep 3, 2020
bdukes
bdukes approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

DNN Platform/Library/Entities/Users/UserController.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Entities/Users/UserController.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Entities/Users/UserController.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Entities/Users/UserController.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Entities/Users/UserController.cs Outdated Show resolved Hide resolved
david-poindexter and others added 5 commits September 3, 2020 16:33
@david-poindexter @bdukes
Update DNN Platform/Library/Entities/Users/UserController.cs
efdccee 
Corrected spelling of length.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@david-poindexter @bdukes
Update DNN Platform/Library/Entities/Users/UserController.cs
3381cf0 
Corrected spelling of deleted.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@david-poindexter @bdukes
Update DNN Platform/Library/Entities/Users/UserController.cs
103dd2e 
Corrected spelling of indicating.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@david-poindexter @bdukes
Update DNN Platform/Library/Entities/Users/UserController.cs
bc1f735 
Corrected spelling of its.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@david-poindexter @bdukes
Update DNN Platform/Library/Entities/Users/UserController.cs
e1c7a25 
Corrected spelling of its.

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
david-poindexter
david-poindexter approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valadas!

@valadas
Copy link
Contributor Author

valadas commented Sep 3, 2020

Thanks for the typo fixes 👍

@david-poindexter david-poindexter merged commit 8bb34af into dnnsoftware:develop Sep 3, 2020
@valadas valadas mentioned this pull request Oct 7, 2020
Closed
1 task
@valadas valadas deleted the user-cache branch April 14, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.7.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valadas @bdukes @david-poindexter @mitchelsellers