Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'DNN Error' to 'Application Error' #4055

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Change 'DNN Error' to 'Application Error' #4055

merged 1 commit into from
Sep 5, 2020

Conversation

thabaum
Copy link
Contributor

@thabaum thabaum commented Sep 5, 2020 •
edited
Loading

Fixes #4054

Summary

Changes "DNN Error" to "Application Error" in ErrorPage.aspx

I was not sure exactly what to change this to in order to make it more generic and accepted by the community. Maintainers more than welcome to make adjustments as needed.

  1. Site Error
  2. Application Error
  3. App Error
  4. Create localization for this along with changing from DNN to one of the above

@thabaum thabaum changed the title Change 'DNN' to 'Application' Change 'DNN Error' to 'Site Error' Sep 5, 2020
@thabaum thabaum changed the title Change 'DNN Error' to 'Site Error' Change 'DNN Error' to 'Application Error' Sep 5, 2020
valadas
valadas approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@valadas valadas added this to the 9.7.2 milestone Sep 5, 2020
bdukes
bdukes approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application Error sounds right to me!

@valadas valadas merged commit 3b5c48b into dnnsoftware:develop Sep 5, 2020
@thabaum thabaum deleted the patch-27 branch December 7, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.7.2
Development

Successfully merging this pull request may close these issues.

Error page says "DNN Error"
3 participants
@thabaum @bdukes @valadas