Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows disabling the editbar using a host setting #4070

Merged
merged 6 commits into from
Sep 9, 2020

Conversation

meetmandeep
Copy link
Contributor

Closes #4038

To Disable Edit Bar

insert into HostSettings values ('DisableEditBar', 'True',0,-1,GETDATE(),-1,GETDATE())

Or (if setting already exists)

update HostSettings
set SettingValue = 'True'
where SettingName = 'DisableEditBar'

To Enable Edit Bar

update HostSettings
set SettingValue = 'False'
where SettingName = 'DisableEditBar'

Or

delete from HostSettings where SettingName = 'DisableEditBar'

Disabled View

If edit bar is disabled, the tooltip reads "Edit Bar is disabled." and help text reads "This DNN installation is running an alternative edit bar."

I couldn't find a way to swap the icon image with another way. Let me know if anyone has any pointers.

image

@mikesmeltzer
Copy link
Contributor

Added some feedback to issue #4038.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me - thanks @meetmandeep

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

…PersonaBarContainer.cs

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@mitchelsellers mitchelsellers added this to the 9.7.2 milestone Sep 9, 2020
@david-poindexter david-poindexter merged commit a2ae132 into dnnsoftware:develop Sep 9, 2020
@meetmandeep meetmandeep deleted the issue-4038 branch September 9, 2020 19:55
@valadas valadas changed the title Issue 4038 Allows disabling the editbar using a host setting Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress Edit Bar
5 participants