Fixed an issue where the React common components would interfere with container css class #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container class Closes dnnsoftware#4107 This scopes the `container` styles inside the `area` class for the Scrollbars common component. It looks like this component is only used once in all our modules in the Pages module for the list of pages scroll area. I have done some testing and it looks all like before.
|
Just adding a little more context for reviewers, the |
david-poindexter
approved these changes
Sep 21, 2020
mitchelsellers
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4107
This scopes the
containerstyles inside theareaclass for the Scrollbars common component. It looks like this component is only used once in all our modules in the Pages module for the list of pages scroll area. I have done some testing and it looks all like before.Before:
After:
