Remove the Improvement Program

[mitchelsellers]

This PR removes all aspects of the Improvement program from the DNN Platform including

• Removal of existing settings
• Removal of injection into Persona Bar & Control Bar
• Removal of all localization keys

@valadas and @david-poindexter Can you verify my work on the ClientSide stuff please.

[bdukes]

For safety's sake, I think I'd prefer that this be marked obsolete and gutted, rather than removed entirely.

[mitchelsellers]

How strongly do you feel about this? Its all internal usage, it sis something that SHOULDN"T be used by third-party. But I can add it back in with an obsolete flag if needed

[bdukes]

I'm happy to be overruled if no one else thinks it's important. I could see a third party using it as a proxy for whether they are going to send their own beacon. I don't know of any actual usages, though, it's just a theory.

[valadas]

Yeah, I am a bit on the fence, but I think this should just have never been made public in the first place and I highly doubt it is used much by third parties. So I am leaning on the side of removing it...

[david-poindexter]

Looks good @mitchelsellers - thanks for doing this! 🎉

[david-poindexter]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[bdukes]

Build error:

2020-09-22T20:48:49.9306901Z          site_settings: Hash: 58bf4bef1db69ca417c5
2020-09-22T20:48:49.9354111Z          site_settings: Version: webpack 4.31.0
2020-09-22T20:48:49.9354904Z          site_settings: Time: 31715ms
2020-09-22T20:48:49.9355358Z          site_settings: Built at: 09/22/2020 8:48:49 PM
2020-09-22T20:48:49.9356079Z          site_settings:  2 assets
2020-09-22T20:48:49.9356739Z          site_settings: Entrypoint main = site-settings-bundle.js site-settings-bundle.js.map
2020-09-22T20:48:49.9357533Z          site_settings:   [0] external "window.dnn.nodeModules.React" 42 bytes {0} [built]
2020-09-22T20:48:49.9358086Z          site_settings:   [3] ./src/utils/index.jsx 207 bytes {0} [built]
2020-09-22T20:48:49.9358648Z          site_settings:   [5] external "window.dnn.nodeModules.ReactRedux" 42 bytes {0} [built]
2020-09-22T20:48:49.9359207Z          site_settings:  [51] external "window.dnn.nodeModules.Redux" 42 bytes {0} [built]
2020-09-22T20:48:49.9359796Z          site_settings: [117] external "window.dnn.nodeModules.ReduxThunk" 42 bytes {0} [built]
2020-09-22T20:48:49.9360403Z          site_settings: [118] (webpack)/buildin/global.js 472 bytes {0} [built]
2020-09-22T20:48:49.9360981Z          site_settings: [158] external "window.dnn.nodeModules.ReactDOM" 42 bytes {0} [built]
2020-09-22T20:48:49.9361603Z          site_settings: [159] external "window.dnn.nodeModules.ReduxImmutableStateInvariant" 42 bytes {0} [built]
2020-09-22T20:48:49.9362224Z          site_settings: [160] external "window.dnn.nodeModules.ReduxDevTools" 42 bytes {0} [built]
2020-09-22T20:48:49.9362851Z          site_settings: [161] external "window.dnn.nodeModules.ReduxDevToolsLogMonitor" 42 bytes {0} [built]
2020-09-22T20:48:49.9363465Z          site_settings: [162] external "window.dnn.nodeModules.ReduxDevToolsDockMonitor" 42 bytes {0} [built]
2020-09-22T20:48:50.0830303Z          site_settings: [163] ./src/containers/Root.js 170 bytes {0} [built]
2020-09-22T20:48:50.0831024Z          site_settings: [368] ./src/less/style.less 1.29 KiB {0} [built]
2020-09-22T20:48:50.0831581Z          site_settings: [466] ./src/containers/Root.prod.js + 60 modules 541 KiB {0} [built] [2 warnings] [1 error]
2020-09-22T20:48:50.0832095Z          site_settings:       | ./src/containers/Root.prod.js 2.85 KiB [built]
2020-09-22T20:48:50.0832561Z          site_settings:       | ./src/actions/index.js 370 bytes [built]
2020-09-22T20:48:50.0833009Z          site_settings:       | ./src/resources/index.jsx 152 bytes [built]
2020-09-22T20:48:50.0833478Z          site_settings:       | ./src/actions/pagination.js 333 bytes [built]
2020-09-22T20:48:50.0833926Z          site_settings:       | ./src/actions/visiblePanel.js 468 bytes [built]
2020-09-22T20:48:50.0834392Z          site_settings:       | ./src/actions/siteInfo.js 2.08 KiB [built]
2020-09-22T20:48:50.0834834Z          site_settings:       | ./src/actions/siteBehavior.js 20.2 KiB [built]
2020-09-22T20:48:50.0835303Z          site_settings:       | ./src/actions/search.js 8.9 KiB [built]
2020-09-22T20:48:50.0835934Z          site_settings:       | ./src/actions/languages.js 11 KiB [built]
2020-09-22T20:48:50.0836449Z          site_settings:       | ./src/actions/languageEditor.js 2.16 KiB [built]
2020-09-22T20:48:50.0836909Z          site_settings:       | ./src/services/applicationService.js 17 KiB [built]
2020-09-22T20:48:50.0837413Z          site_settings:       | ./src/services/languageEditorService.js 4.2 KiB [built]
2020-09-22T20:48:50.0837879Z          site_settings:       |     + 49 hidden modules
2020-09-22T20:48:50.0838316Z          site_settings: [467] ./src/main.jsx + 11 modules 27.6 KiB {0} [built]
2020-09-22T20:48:50.0838740Z          site_settings:       | ./src/main.jsx 530 bytes [built]
2020-09-22T20:48:50.0839189Z          site_settings:       | ./src/globals/application.js 1.02 KiB [built]
2020-09-22T20:48:50.0839661Z          site_settings:       | ./src/store/configureStore.js 645 bytes [built]
2020-09-22T20:48:50.0840110Z          site_settings:       | ./src/reducers/rootReducer.js 1.14 KiB [built]
2020-09-22T20:48:50.0840583Z          site_settings:       | ./src/containers/DevTools.js 355 bytes [built]
2020-09-22T20:48:50.0841052Z          site_settings:       | ./src/reducers/paginationReducer.js 1.15 KiB [built]
2020-09-22T20:48:50.0841544Z          site_settings:       | ./src/reducers/visiblePanelReducer.js 1.28 KiB [built]
2020-09-22T20:48:50.0842118Z          site_settings:       | ./src/reducers/siteInfoReducer.js 1.93 KiB [built]
2020-09-22T20:48:50.0842609Z          site_settings:       | ./src/reducers/siteBehaviorReducer.js 8.94 KiB [built]
2020-09-22T20:48:50.0843079Z          site_settings:       | ./src/reducers/languagesReducer.js 4.13 KiB [built]
2020-09-22T20:48:50.0843561Z          site_settings:       | ./src/reducers/searchReducer.js 3.79 KiB [built]
2020-09-22T20:48:50.0844034Z          site_settings:       | ./src/reducers/languageEditorReducer.js 2.71 KiB [built]
2020-09-22T20:48:50.0844474Z          site_settings:     + 453 hidden modules
2020-09-22T20:48:50.0844856Z          site_settings: WARNING in ./src/components/App.jsx
2020-09-22T20:48:50.0845338Z          site_settings: Module Warning (from D:/a/1/s/node_modules/eslint-loader/index.js):
2020-09-22T20:48:50.0845875Z          site_settings: D:\a\1\s\Dnn.AdminExperience\ClientSide\SiteSettings.Web\src\components\App.jsx
2020-09-22T20:48:50.0846436Z          site_settings:   113:16  warning  'state' is assigned a value but never used  no-unused-vars
2020-09-22T20:48:50.0846966Z          site_settings:   113:23  warning  'props' is assigned a value but never used  no-unused-vars
2020-09-22T20:48:50.0847494Z          site_settings: Γ£û 2 problems (0 errors, 2 warnings)
2020-09-22T20:48:50.0848058Z          site_settings:  @ ./src/containers/Root.prod.js 20:0-36 40:29-32
2020-09-22T20:48:50.0848496Z          site_settings:  @ ./src/containers/Root.js
2020-09-22T20:48:50.0848846Z          site_settings:  @ ./src/main.jsx
2020-09-22T20:48:50.0849265Z          site_settings: WARNING in ./src/components/moreSettings/index.jsx
2020-09-22T20:48:50.0849747Z          site_settings: Module Warning (from D:/a/1/s/node_modules/eslint-loader/index.js):
2020-09-22T20:48:50.0850327Z          site_settings: D:\a\1\s\Dnn.AdminExperience\ClientSide\SiteSettings.Web\src\components\moreSettings\index.jsx
2020-09-22T20:48:50.0850860Z          site_settings:    48:62  warning  Expected '===' and instead saw '=='  eqeqeq
2020-09-22T20:48:50.0851382Z          site_settings:    53:62  warning  Expected '===' and instead saw '=='  eqeqeq
2020-09-22T20:48:50.0851859Z          site_settings:   347:68  warning  Expected '===' and instead saw '=='  eqeqeq
2020-09-22T20:48:50.0852344Z          site_settings: Γ£û 3 problems (0 errors, 3 warnings)
2020-09-22T20:48:50.0852809Z          site_settings:  @ ./src/components/body/index.jsx 34:0-43 96:32-44 118:32-44
2020-09-22T20:48:50.0853264Z          site_settings:  @ ./src/components/App.jsx
2020-09-22T20:48:50.0853806Z          site_settings:  @ ./src/containers/Root.prod.js
2020-09-22T20:48:50.0854205Z          site_settings:  @ ./src/containers/Root.js
2020-09-22T20:48:50.0854557Z          site_settings:  @ ./src/main.jsx
2020-09-22T20:48:50.0854974Z          site_settings: ERROR in ./src/components/privacySettings/index.jsx
2020-09-22T20:48:50.0855459Z          site_settings: Module Error (from D:/a/1/s/node_modules/eslint-loader/index.js):
2020-09-22T20:48:50.0856050Z          site_settings: D:\a\1\s\Dnn.AdminExperience\ClientSide\SiteSettings.Web\src\components\privacySettings\index.jsx
2020-09-22T20:48:50.0856584Z          site_settings:   365:38  error  'columnOneRight' is not defined  no-undef
2020-09-22T20:48:50.0857063Z          site_settings: Γ£û 1 problem (1 error, 0 warnings)
2020-09-22T20:48:50.0857543Z          site_settings:  @ ./src/components/body/index.jsx 29:0-49 93:32-47 115:32-47
2020-09-22T20:48:50.0858004Z          site_settings:  @ ./src/components/App.jsx
2020-09-22T20:48:50.0858404Z          site_settings:  @ ./src/containers/Root.prod.js
2020-09-22T20:48:50.0858777Z          site_settings:  @ ./src/containers/Root.js
2020-09-22T20:48:50.0859127Z          site_settings:  @ ./src/main.jsx
2020-09-22T20:48:50.1195540Z          site_settings: error Command failed with exit code 2.
2020-09-22T20:48:50.1543709Z          site_settings: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2020-09-22T20:48:50.1734050Z          lerna ERR! yarn run build exited 2 in 'site_settings'
2020-09-22T20:48:50.1734857Z          lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.
2020-09-22T20:48:50.3461954Z     17>D:\a\1\s\Build\BuildScripts\AEModule.build(49,5): error : Command failed with exit code 2. [D:\a\1\s\Dnn.AdminExperience\Dnn.PersonaBar.Extensions\Dnn.PersonaBar.Extensions.csproj]
2020-09-22T20:48:50.3650237Z          info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[mitchelsellers]

Weird, I'll have to double check what I messed up

[david-poindexter]

I have seen similar build issues before and it is due to version mismatching. Leaving Version blank in settings.local.json seemed to fix it.