Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue where Dnn would not install #4136

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Fixes an issue where Dnn would not install #4136

merged 1 commit into from
Sep 28, 2020

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Sep 27, 2020

  • Removes empty 09.07.03.config file
  • Includes other config files in project so they are visible in Visual Studio

Closes #4135

Summary

@valadas
- Removes empty 09.07.03.config
ef6c62f 
- Includes files in project
@valadas valadas added this to the 9.7.3 milestone Sep 27, 2020
mitchelsellers
mitchelsellers reviewed Sep 27, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A prior PR had a config element in it though? Did that file content get lost?

@valadas
Copy link
Contributor Author

valadas commented Sep 27, 2020

A prior PR had a config element in it though? Did that file content get lost?

Oh, then yeah, that got lost, on develop that file is empty...

@valadas
Copy link
Contributor Author

valadas commented Sep 27, 2020

But I am not seeing that in the file history https://github.com/dnnsoftware/Dnn.Platform/commits/develop/DNN%20Platform/Website/Install/Config/09.07.03.config

You have any reference to that content @mitchelsellers ?

@mitchelsellers
Copy link
Contributor

It was on the removal of the Beacon

@valadas
Copy link
Contributor Author

valadas commented Sep 28, 2020

After discussion with @mitchelsellers , holding this for the actual content that should have been in this file...

@mitchelsellers
Copy link
Contributor

@valadas I will not be until tomorrow that I can re-create this. It was the removal of the appSetting Key for the ImprovementService URL

@bdukes
Copy link
Contributor

bdukes commented Sep 28, 2020

Can we just merge this as-is, and the upcoming PR will add the file back?

@mitchelsellers
Copy link
Contributor

@bdukes Yes, I'll merge now

@mitchelsellers mitchelsellers merged commit 4b7fa6c into dnnsoftware:develop Sep 28, 2020
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
@valadas valadas deleted the issue-4135 branch April 14, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers left review comments

@bdukes bdukes bdukes approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.

Current develop branch builds but won't install
4 participants
@valadas @mitchelsellers @bdukes @david-poindexter