Removed Module Creator from distribution #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the Module Creator admin module from the distribution as per it's move to https://github.com/DNNCommunity/Dnn.ModuleCreator/releases/tag/v9.8.1 - Also reduces build warnings by about 46
bdukes
reviewed
Oct 19, 2020
|
Oh sorry, forgot to link the isssue #3620 Basically the reasoning was that it's something for developers and should not be part of the base install. On the linked repository I took the existing code and fixed all warnings for deprecations and made it a standalone buildable solution. People who do need this module can grab it from there and it makes the base distribution lighter. |
bdukes
approved these changes
Oct 19, 2020
|
Are we good with this in 9.8.1 or we slate it for later (10) ? Just for context, it would not affect upgrades but new installs would not have the ModuleCreator in it. |
|
@valadas I am thinking it is good for 9.8.1 |
david-poindexter
approved these changes
Oct 22, 2020
|
I put a |
mitchelsellers
approved these changes
Oct 23, 2020
bdukes
added a commit
to bdukes/Dnn.Platform
that referenced
this pull request
Feb 15, 2021
As of DNN 9.8.1, Module Creator is not included in the distribution of DNN (see dnnsoftware#4208)
soheilkheiri
pushed a commit
to DnnSoftwarePersian/Dnn.Platform
that referenced
this pull request
Mar 1, 2021
As of DNN 9.8.1, Module Creator is not included in the distribution of DNN (see dnnsoftware#4208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3620