Support for secure settings in settings serialization #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equires more debate on how to best do this.
bdukes
approved these changes
Nov 24, 2020
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
…ory.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ory.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ory.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ory.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ory.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
donker
changed the title
|
I've expanded the scope to all types of settings: host, portal, module and tabmodule. It makes sense to have this available for all and it improves the symmetry of the solution. |
bdukes
approved these changes
Nov 30, 2020
donker
commented
Nov 30, 2020
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
bdukes
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the settings support we have for modules. With this PR you can now store a setting securely.