Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check user permissions unless there's a user #4356

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Don't check user permissions unless there's a user #4356

merged 1 commit into from
Dec 14, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Dec 11, 2020

Fixes #4355

@bdukes bdukes added this to the 9.8.1 milestone Dec 11, 2020
@bdukes
Copy link
Contributor Author

bdukes commented Dec 11, 2020

@mitchelsellers it was only pulling userId from the query string, so it shouldn't cause a problem, but I went ahead and adjusted the logic to be based on mode instead.

@bdukes bdukes requested a review from valadas December 14, 2020 18:52
valadas
valadas approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas merged commit e837d96 into dnnsoftware:develop Dec 14, 2020
@bdukes bdukes deleted the imagehandler-403-fix branch December 14, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.8.1
Development

Successfully merging this pull request may close these issues.

DNN ImageHandler is broken in 9.8.0
3 participants
@bdukes @mitchelsellers @valadas