Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up warnings in CKEditorProvider #4374

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Clean up warnings in CKEditorProvider #4374

merged 1 commit into from
Dec 21, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Dec 16, 2020

26 obsolete warnings remain

valadas
valadas previously requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments here and there, otherwise it looks good to me.

DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Browser/Browser.aspx.cs Outdated Show resolved Hide resolved
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Web/EditorControl.cs Outdated Show resolved Hide resolved
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Web/EditorControl.cs Outdated Show resolved Hide resolved
@valadas valadas added this to the 9.8.1 milestone Dec 17, 2020
@bdukes bdukes force-pushed the warnings-ckeditor-provider branch 2 times, most recently from 4b134fc to f12cea7 Compare December 17, 2020 16:15
@bdukes @valadas
Clean up warnings in CKEditorProvider
75c116e 
26 obsolete warnings remain

Co-authored-by: Daniel Valadas <info@danielvaladas.com>
@bdukes
Copy link
Contributor Author

bdukes commented Dec 17, 2020

FYI, I have already rebased #4383 on these changes locally, the conflicts are already taken case of

@donker donker dismissed valadas’s stale review December 21, 2020 21:53

Resolved by Brian

@donker donker merged commit 59125c4 into dnnsoftware:develop Dec 21, 2020
@bdukes bdukes deleted the warnings-ckeditor-provider branch December 22, 2020 14:44
@bdukes bdukes mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donker donker donker approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas left review comments

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bdukes @donker @mitchelsellers @valadas