Feature/fix cke link popup #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4426
Summary
I found an issue with the link popup in the update CKEditor provider, after my PR #4383 was merged.
Opening the link popup of the editor, when there is no content in the editor, results in a javascript error.
This was caused by the dnnpages plugin.
It turns out that the dnnpages plugin is a copy of the link plugin, with some changes to facilite the portal-page dropdown. So to fix this is issue, I compared the existing dnnpages plugin.js to the original plugin.js of the link plugin of CKE 4.5.3 (the old one) and implemented the same changes in a fresh copy of the link plugin of CKE 4.15.
Also I found that jquery.ckeditor.adapter.js is now in CKE itself, so the extra js file isn't needed anymore.