removed languages not provided in dnnpages plugin #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can guide me to what is needed to fix languages I could fix fr or maybe some others... |
|
Oh, I should have looked before asking 😄 I added french... |
|
Can you add Dutch to this, @skamphuis ? Since we support that language quite well ... |
|
Sure, will do that tomorrow. I had that, to be honest, but found it a bit "selfish" and was thinking about a solution to make all of the editor provider localizable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upgraded dnnpages-plugin for CKEditor, I left the full list of langues. Since only 3 (en,de,pl) language files are actually supported currently, the others result in an error.
This simple removal provides the same solution we had before.
I skipped creating an issue this time, since it's not in a RC yet, anyway. If needed, I'm happy to create one, of course.