Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cake to 1.0.0-RC3 #4433

Merged
merged 7 commits into from
Feb 1, 2021
Merged

Upgrade Cake to 1.0.0-RC3 #4433

merged 7 commits into from
Feb 1, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jan 25, 2021

We're currently using RC1 of Cake 1.0.0 and RC2 was recently released.

@bdukes
Copy link
Contributor Author

bdukes commented Jan 26, 2021

Looks like this is running into an issue with cake-build/cake#3038, so this PR can hang out until next Cake release

@bdukes
Copy link
Contributor Author

bdukes commented Jan 26, 2021

I did adjust this in a way to work around the RC2 issue, so this does appear to be working if we want to merge. No hurry.

@bdukes bdukes changed the title Upgrade Cake to 1.0.0-RC2 Upgrade Cake to 1.0.0-RC3 Feb 1, 2021
@bdukes
Copy link
Contributor Author

bdukes commented Feb 1, 2021

I've updated to the Cake 1.0.0-RC3 release, which is working fine now.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valadas valadas merged commit 5b4fab9 into dnnsoftware:develop Feb 1, 2021
@bdukes bdukes deleted the upgrade-cake branch February 3, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants