Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Deterministic Builds #4450

Merged

Conversation

mitchelsellers
Copy link
Contributor

Summary

Implemented the flag for deterministic builds for all projects in the solution to help align with desired implementations from the .NET Foundation.

NOTE: We will want to verify build status. I verified local builds seem to be ok.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me providing everything builds

@bdukes
Copy link
Contributor

bdukes commented Feb 4, 2021

Reviewing the produced NuGet packages in @clairernovotny's NuGet Package Explorer, here are the results:

Package Source Link Deterministic Compiler Flags
DotNetNuke.WebApi 🟢 No files found to validate 🟢 No files found to validate 🟢 No files found to validate
DotNetNuke.Abstractions 🔴 Has Symbols, No Source Link 🟢 Valid 🟢 Present
DotNetNuke.DependencyInjection 🔴 Has Symbols, No Source Link 🟢 Valid 🟢 Present
Dnn.PersonaBar.Library 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Instrumentation 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Providers.FolderProviders 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.SiteImportExport 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Web 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Web.Client 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Web.Mvc 🔴 Has Symbols, No Source Link 🟢 Valid 🔴 Missing
DotNetNuke.Core 🔴 Missing Symbols 🔴 Non deterministic (missing symbols for Microsoft.ApplicationBlocks.Data) 🔴 Missing
DotNetNuke.Bundle 🔴 Missing Symbols 🔴 Non deterministic (missing symbols for DotNetNuke.WebControls) 🔴 Missing
DotNetNuke.Web.Deprecated 🔴 Missing Symbols 🔴 Non deterministic (missing symbols for Telerik.Web.UI) 🔴 Missing

So, it looks like our SDK-style projects are automatically "correct", and our third party dependencies need to include symbols (though I'm not sure what that has to do with being deterministic…).

I'm okay with merging this as-is and tackling these other issues separately.

@donker donker merged commit 7fdf818 into dnnsoftware:develop Feb 5, 2021
@mitchelsellers mitchelsellers deleted the feature/DeterministicBuilds branch September 21, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants