Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from moment to dayjs for Sites.Web #4459

Merged

Conversation

david-poindexter
Copy link
Contributor

Summary

This is related to #3875 and is for the Sites.Web project.

  • moment replaced with dayjs
  • ClientSide project name changed from boilerplate (wtf) to sites

@david-poindexter david-poindexter added this to the 9.9.0 milestone Feb 7, 2021
@david-poindexter david-poindexter self-assigned this Feb 7, 2021
@david-poindexter david-poindexter mentioned this pull request Feb 7, 2021
18 tasks
@david-poindexter david-poindexter changed the title Migrate from moment to dayjs Migrate from moment to dayjs for Sites.Web Feb 7, 2021
@david-poindexter
Copy link
Contributor Author

Please hold on merging this because I need to correct the version numbers.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the version nit which does not matter really as the build will override it but if you can just revert the version number it would look nicer...

@david-poindexter
Copy link
Contributor Author

Looks good to me other than the version nit which does not matter really as the build will override it but if you can just revert the version number it would look nicer...

@valadas the version numbers have now been corrected. I am not clear as to how they ever got changed in the first place. 🤷🏼‍♂️

@mitchelsellers mitchelsellers merged commit 5080731 into dnnsoftware:develop Feb 8, 2021
@david-poindexter david-poindexter deleted the issue-3875-sites branch May 31, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants