Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build documentation #4460

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Conversation

donker
Copy link
Contributor

@donker donker commented Feb 7, 2021

Add documentation to build React projects. Upon request :-)

@donker donker added this to the 9.9.0 milestone Feb 7, 2021
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and don't let my comment hold this, but just a little nit, not all projects are React. If you have time and could rephrase React to Node projects...

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks @donker 🎉

@david-poindexter david-poindexter merged commit 235c96c into dnnsoftware:develop Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants