Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate moment to dayjs for Dnn.React.Common #4466

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Migrate moment to dayjs for Dnn.React.Common #4466

merged 1 commit into from
Feb 8, 2021

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Feb 8, 2021 •
edited
Loading

Summary

Migrate moment to dayjs for Dnn.React.Common - relates to #3875

@david-poindexter david-poindexter added this to the 9.9.0 milestone Feb 8, 2021
@david-poindexter david-poindexter self-assigned this Feb 8, 2021
valadas
valadas approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...

For v.10 I think it would be a good idea to investigate the other externals that are unused, this could seriously reduce the common bundle size.

The goal I think was that modules would use the ones from the common bundle, but most of the time it looks like that is not even the case.

Anyway, just a note, nothing that has to do with this PR.

@david-poindexter
Copy link
Contributor Author

Looks good...

For v.10 I think it would be a good idea to investigate the other externals that are unused, this could seriously reduce the common bundle size.

The goal I think was that modules would use the ones from the common bundle, but most of the time it looks like that is not even the case.

Anyway, just a note, nothing that has to do with this PR.

Agreed 💯

@valadas valadas merged commit 13f7f4f into dnnsoftware:develop Feb 8, 2021
@david-poindexter david-poindexter mentioned this pull request Feb 8, 2021
Closed
18 tasks
@david-poindexter david-poindexter deleted the issue-3875-dnn-react-common branch May 31, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Type: Enhancement
Projects
None yet
Milestone
9.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-poindexter @mitchelsellers @valadas