Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit values to all enums #4474

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Feb 9, 2021

Fixes #4289

@bdukes bdukes added this to the 9.9.0 milestone Feb 9, 2021
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas merged commit d223ba4 into dnnsoftware:develop Feb 9, 2021
@bdukes bdukes deleted the explicit-enum-values branch February 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Explicitly Specifying Enumeration Values Can Lead to Unexpected Results
3 participants