Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PersonaBar loading when within an iframe #4492

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

jmbockhorst
Copy link
Contributor

Fixes #4491.

Summary

This change has been working for me for months and I haven't noticed any other regressions, but I'm not sure what other things this might affect.

@dnfadmin
Copy link

dnfadmin commented Feb 12, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me. This might also make it work with broswersync :) Thanks!

@valadas valadas added this to the 9.9.1 milestone Feb 12, 2021
@valadas valadas merged commit 52d947b into dnnsoftware:develop Feb 12, 2021
@jmbockhorst jmbockhorst deleted the iframe-testing branch February 12, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersonaBar doesn't load when within an iframe
5 participants