Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure page css #4500

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Azure page css #4500

merged 5 commits into from
Feb 23, 2021

Conversation

msant7
Copy link
Contributor

@msant7 msant7 commented Feb 17, 2021

Fixes #4499

Summary

  1. To support Page Stylesheets stored in AzureFolderProvider (and others). Attempt to get the Page Stylesheet from the FolderProvider first. If it exists with an external url, then include the css in a page header link. If not, include through ClientResourceMananger (current way)
  2. Add CSS contenttype to FileContentTypeManager.cs and Database Lists of type 'ContentTypes'. If this doesn't exist .css will be uploaded as 'application/octet-stream' and browsers won't use it as a css file.

bdukes
bdukes reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

DNN Platform/Website/Default.aspx.cs Outdated Show resolved Hide resolved
DNN Platform/Website/Default.aspx.cs Outdated Show resolved Hide resolved
DNN Platform/Website/Providers/DataProviders/SqlDataProvider/09.09.01.SqlDataProvider Outdated Show resolved Hide resolved
DNN Platform/Website/Providers/DataProviders/SqlDataProvider/09.09.01.SqlDataProvider Outdated Show resolved Hide resolved
@bdukes bdukes added this to the 9.9.1 milestone Feb 17, 2021
msant7 and others added 3 commits February 22, 2021 06:04
@msant7 @bdukes
Update DNN Platform/Website/Providers/DataProviders/SqlDataProvider/0…
07d7b37 
…9.09.01.SqlDataProvider

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@msant7 @bdukes
Update DNN Platform/Website/Providers/DataProviders/SqlDataProvider/0…
1574d99 
…9.09.01.SqlDataProvider

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
refactor including the CustomStyleSheet after fixing an issue in Clie…
91f620e 
…ntResourceManager.Register Stylesheet
bdukes
bdukes approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mitchelsellers mitchelsellers merged commit 9db0746 into dnnsoftware:develop Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.9.1
Development

Successfully merging this pull request may close these issues.

Page Style Sheet can not be used with AzureFolderProvider
3 participants
@msant7 @bdukes @mitchelsellers