Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust .editorconfig #4530

Merged
merged 3 commits into from
Feb 27, 2021
Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Feb 26, 2021

Summary

The .editorconfig had some rules that conflicted with the StyleCop rules.

Remove reference to build.cake that was removed earlier (c8b03ba)
Add .editorconfig and azure-pipelines.yml
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @bdukes 🎉

@bdukes bdukes force-pushed the editorconfig branch 2 times, most recently from 8498cca to 74b40fe Compare February 26, 2021 20:37
Fix conflicting rules regarding "this." prefix
Remove rules specifying prefix which conflicts with StyleCop config
Remove duplicate rules from tests .editorconfig
Fix conflicting rules regarding "this." prefix
Remove rules specifying prefix which conflicts with StyleCop config
Remove duplicate rules from tests .editorconfig
@david-poindexter
Copy link
Contributor

@bdukes is this one ready to merge now?

@bdukes
Copy link
Contributor Author

bdukes commented Feb 27, 2021

@david-poindexter yes, it's good now.

@david-poindexter david-poindexter merged commit c93ddef into dnnsoftware:develop Feb 27, 2021
@david-poindexter david-poindexter deleted the editorconfig branch February 27, 2021 18:16
soheilkheiri pushed a commit to DnnSoftwarePersian/Dnn.Platform that referenced this pull request Mar 1, 2021
* Adjust solution items

Remove reference to build.cake that was removed earlier (c8b03ba)
Add .editorconfig and azure-pipelines.yml

* Adjust .editorconfig files

Fix conflicting rules regarding "this." prefix
Remove rules specifying prefix which conflicts with StyleCop config
Remove duplicate rules from tests .editorconfig

* Adjust .editorconfig files

Fix conflicting rules regarding "this." prefix
Remove rules specifying prefix which conflicts with StyleCop config
Remove duplicate rules from tests .editorconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants