Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where CK-Editor provider did not include image files in install package #4546

Conversation

skamphuis
Copy link
Contributor

Fixes #4537

Summary

In a previous PR I moved images and icons out of the ckeditor folder, since they really where not related to the editor, but the provider itself. In issue #4537 it was pointed out that the moved images are currently not included in the install package.
This PR fixes that by changing the build file.

Tested with a new install from the develop branch.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@valadas valadas added this to the 9.9.1 milestone Mar 7, 2021
@valadas valadas changed the title Fixes #4537 (CK-Editor provider) Include image files in install package Fixed an issue where CK-Editor provider did not include image files in install package Mar 7, 2021
@mitchelsellers mitchelsellers merged commit 257312d into dnnsoftware:develop Mar 8, 2021
@skamphuis skamphuis deleted the feature/4537-CKE-files-missing-form-install branch November 23, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.9.0 CKEditor config: Icon legend image files not found
3 participants