fixed redirect to primary alias when PortalAliasMapping is set to redirect #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PortalAliasMapping is set to redirect, and the request is not for the primary alias, user will be redirected
mitchelsellers
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
This appears to be a good change and makes sense with the expected behavior. We want to be sure that we add this to the final testing for the next release @valadas
skamphuis
deleted the
feature/4306-PortalAlias-redirecting-when-PortalAliasMapping-is-set-to-redirect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4306
If PortalAliasMapping is set to redirect, and the request is not for the primary alias, user will be redirected
Summary
In advancedUrlRewriter.IsPortalAliasIncorrect there was a check to allow redirection to an alias when forceAlias was used in the querystring.
I added to that check that if the request is not for a primary alias, and PortalAliasMapping is set to redirect, the user will also be redirected to the primary alias