Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for MailKit #4575

Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Mar 30, 2021

Fixes #4563

I haven't had a chance to test that this does the right thing, waiting for the generated packages to check.

Also, I'd like to adjust how we're generating these to read the versions and update the manifest magically, but haven't gotten to that yet.

@bdukes bdukes added this to the 9.9.1 milestone Mar 30, 2021
@mitchelsellers
Copy link
Contributor

@bdukes I think the only other thing we need to do here is also exclude these files from the created install/upgrade packages correct?

@bdukes
Copy link
Contributor Author

bdukes commented Mar 30, 2021

@mitchelsellers they're excluded from the packages in Build/Tasks/packaging.json

@bdukes
Copy link
Contributor Author

bdukes commented Mar 31, 2021

Alright, I think this is ready for review. The manifest version and assembly versions are automatically set during packaging. I've done an install and an upgrade from 9.8.1 to 9.9.1 and verified that the MailKitMailProvider works on both sites.

One thing to note is that I did not get a MailKitMailProvider entry added to the web.config upon upgrade, I had to add it manually. I don't think that's related to these changes, but perhaps another issue we need to investigate.

@valadas
Copy link
Contributor

valadas commented Apr 5, 2021

[x] v9.9.1 Clean install: Emails work and mailkit is available but not set a default
[x] v9.9.0 pre-configures for MailKit, stays configured with MailKit and still works
[ ] v9.1.1 upgrade emails keep working but MailKit is not available in the web.config providers. What is the plan for this ? merge this PR and do another one for that ?

Other than that, it looks good to me.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if we handle the upgrade adding of the provider in the web.config separatelly...

@valadas
Copy link
Contributor

valadas commented Apr 5, 2021

I think #4582 will fix the web.config part of this, waiting for the build to confirm that...

@mitchelsellers mitchelsellers merged commit b22c471 into dnnsoftware:develop Apr 6, 2021
@mitchelsellers mitchelsellers deleted the mailkit-separate-install branch April 6, 2021 18:18
bdukes added a commit to bdukes/Dnn.Platform that referenced this pull request Apr 8, 2021
It's added via the MailKit package from dnnsoftware#4575

Fixes dnnsoftware#4525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DotNetNuke Library Package for MailKit
3 participants