-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package for MailKit #4575
Add package for MailKit #4575
Conversation
@bdukes I think the only other thing we need to do here is also exclude these files from the created install/upgrade packages correct? |
2fcb97a
to
36fc364
Compare
@mitchelsellers they're excluded from the packages in |
36fc364
to
dc39227
Compare
dc39227
to
8753b7c
Compare
Alright, I think this is ready for review. The manifest version and assembly versions are automatically set during packaging. I've done an install and an upgrade from 9.8.1 to 9.9.1 and verified that the One thing to note is that I did not get a |
[x] v9.9.1 Clean install: Emails work and mailkit is available but not set a default Other than that, it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if we handle the upgrade adding of the provider in the web.config separatelly...
I think #4582 will fix the web.config part of this, waiting for the build to confirm that... |
It's added via the MailKit package from dnnsoftware#4575 Fixes dnnsoftware#4525
Fixes #4563
I haven't had a chance to test that this does the right thing, waiting for the generated packages to check.
Also, I'd like to adjust how we're generating these to read the versions and update the manifest magically, but haven't gotten to that yet.