Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary logger instead of console logger for speedier builds #4576

Merged
merged 5 commits into from
Apr 1, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Mar 31, 2021

See https://msbuildlog.com/ for the log viewer and other details on binary logs.

Zero indicates passing /m to MSBuild, allowing it to use up to the
number of processors on the computer. See
https://docs.microsoft.com/en-us/visualstudio/msbuild/building-multiple-projects-in-parallel-with-msbuild
@bdukes bdukes added this to the 9.9.1 milestone Mar 31, 2021
@bdukes
Copy link
Contributor Author

bdukes commented Apr 1, 2021

This PR turns off the console logger during CI and produces a binary log file (which gets included in the Artifacts). It then reads the log file and reports warnings all at once. This appears to save at least a couple of minutes of build time. The binary log also has more complete details if there's an issue to investigate (the downside being the friction of needing a separate tool to interrogate it).

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, clean and faster builds

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@valadas valadas merged commit e026503 into dnnsoftware:develop Apr 1, 2021
@bdukes bdukes deleted the binlog branch September 20, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants