Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where custom Analyzer types generate System.MissingMethodException #4824

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

berkarslan-xo
Copy link
Contributor

Fixes #4823

Summary

If a parameterless constructor doesn't exist, the constructor with "Version" parameter is used instead if exists.

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, it looks good with just a couple of small adjustments. Thanks!

@bdukes bdukes added this to the 9.10.2 milestone Sep 9, 2021
@berkarslan-xo berkarslan-xo changed the title Bugfix/issue 4823 Custom Analyzer types generate System.MissingMethodException Sep 9, 2021
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@valadas valadas merged commit df67ceb into dnnsoftware:develop Sep 9, 2021
@valadas valadas changed the title Custom Analyzer types generate System.MissingMethodException Fixed an issue where custom Analyzer types generate System.MissingMethodException Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Analyzer types generate System.MissingMethodException
3 participants