Fixed an issue where it was impossible to edit html on child portals #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where it was impossible to edit html on child portals. Closes dnnsoftware#4791
- Removes unhelpful comments on private methods - Renames some variables and methods for better code clarity - Updates some comments on public methods - Removes commented out code
valadas
commented
Sep 14, 2021
Comment on lines
401
to
+403
| // cloudservices variables need to be set regardless | ||
| this.settings.Add("cloudServices_tokenUrl", "/API/CKEditorProvider/CloudServices/GetToken"); | ||
| var tokenUrl = ServicesFramework.GetServiceFrameworkRoot() + "API/CKEditorProvider/CloudServices/GetToken"; | ||
| this.settings.Add("cloudServices_tokenUrl", tokenUrl); |
There was a problem hiding this comment.
Meh, my commits got mixed up, the end result is still fine but this is basically the fix
There was a problem hiding this comment.
And thanks to @bdukes for the hint on the simpler solution than I had in head 😄
bdukes
approved these changes
Sep 14, 2021
| /// <returns> | ||
| /// Returns if it has rendered text area. | ||
| /// </returns> | ||
| /// <param name="control">The control to ckeck.</param> |
There was a problem hiding this comment.
Suggested change
| /// <param name="control">The control to ckeck.</param> | |
| /// <param name="control">The control to check.</param> |
| @@ -804,7 +757,7 @@ public bool LoadPostData(string postDataKey, NameValueCollection postCollection) | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// The raise post data changed event. | |||
| /// Taises post data changed event. | |||
There was a problem hiding this comment.
Suggested change
| /// Taises post data changed event. | |
| /// Raises the post data changed event. |
mitchelsellers
approved these changes
Sep 14, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where it was impossible to edit html on child portals.
Closes #4791
I have also cleaned up the file a bit
For an easier review, the bug is the first commit and the other commits are cleanup.