Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RestSharp reference #4838

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Remove unused RestSharp reference #4838

merged 1 commit into from
Sep 22, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Sep 21, 2021

Supersedes #4781

@bdukes bdukes added this to the 9.10.2 milestone Sep 21, 2021
mitchelsellers
mitchelsellers approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, one less dependency.

@bdukes
Copy link
Contributor Author

bdukes commented Sep 21, 2021

We never actually shipped the RestSharp assembly, so it wasn't a runtime dependency, just something referenced in the build

valadas
valadas approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit 09d572a into dnnsoftware:develop Sep 22, 2021
@bdukes bdukes deleted the remove-restsharp branch January 19, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdukes @mitchelsellers @valadas