Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WebFormsMVP from 1.4.1.0 to 1.4.5 #4863

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 5, 2021

Bumps WebFormsMVP from 1.4.1.0 to 1.4.5.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code Type: Maintenance labels Oct 5, 2021
Bumps WebFormsMVP from 1.4.1.0 to 1.4.5.

---
updated-dependencies:
- dependency-name: WebFormsMVP
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@bdukes bdukes force-pushed the dependabot/nuget/WebFormsMVP-1.4.5 branch from 985cfe0 to bf2cbad Compare October 5, 2021 19:28
@stale
Copy link

stale bot commented Jan 9, 2022

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jan 9, 2022
@valadas valadas removed the stale label Jan 9, 2022
@mitchelsellers
Copy link
Contributor

Needs to be converted to a package to support binding redirects

@bdukes bdukes added this to the 9.10.3 milestone Jan 25, 2022
@bdukes
Copy link
Contributor

bdukes commented Jan 25, 2022

I've added a package for WebFormsMvp

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@valadas
Copy link
Contributor

valadas commented Feb 16, 2022

@bdukes I may have broke the interwebs by resolving the conflict in the browser here, just to confirm:
The left syntax is the right one but with the items on the right ?
image

@bdukes
Copy link
Contributor

bdukes commented Feb 16, 2022

Correct, it needs to use the IsDependentOn attribute, but also include the PackageWebFormsMvp dependency

@valadas
Copy link
Contributor

valadas commented Feb 16, 2022

Ok, I just pushed a commit to fix that, let's see if that builds

@valadas valadas merged commit 3fc4cac into develop Feb 16, 2022
@dependabot dependabot bot deleted the dependabot/nuget/WebFormsMVP-1.4.5 branch February 16, 2022 21:29
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants