Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade knockout js to 3.5.1. #4868

Merged

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Oct 11, 2021

brining current.

@bdukes
Copy link
Contributor

bdukes commented Oct 11, 2021

3.4.0 release notes:

Possible compatibility issues

  • Components now use microtasks to perform updates asynchronously instead of setTimeout. Since microtasks are run before the browser repaints the page, all loaded components will be initialized and displayed in a single repaint. Although this reduces the overall time needed to display components, it could result in a longer delay before anything is displayed.
  • The new, native deferred updates feature has a slightly different API and is implemented differently than the Deferred Updates plugin. Migrating from the plugin will generally require some code changes (full details to come soon).
  • ko.observable and ko.computed no longer use a closure when defining their methods, such as dispose and valueHasMutated. These functions expect this to be set correctly and so can't be used directly as a callback. Instead you'll need to use bind, such as obs.dispose.bind(obs).

3.5.0 release notes:

Important: This release includes some minor breaking changes to the foreach binding to improve performance and clarify features. These changes can be turned off using global options.

  • When using the as option with the foreach binding, Knockout will set the named value for each item in the array but won't create a child context. In other words, when using as, you will have to use the named value in bindings: text: item.property rather than text: property. This can be controlled by setting ko.options.createChildContextWithAs = true. (See #907)
  • To improve performance when array changes are from a known, single operation, such as push, the foreach binding no longer filters out destroyed items by default. To turn this off and filter out destroyed items, you can set includeDestroyed: false in the foreach binding or set ko.options.foreachHidesDestroyed = true to use the previous behavior by default. (See #2324)

@mitchelsellers
Copy link
Contributor

I've added this to the Agenda item to discuss tomorrow (Tuesday) at the Git Approvers meeting

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, will be included in the 9.11.0 release

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@valadas valadas added this to the 9.11.0 milestone Nov 7, 2021
@bdukes bdukes changed the base branch from release/9.10.2 to release/9.11.0 November 12, 2021 20:56
@bdukes
Copy link
Contributor

bdukes commented Nov 12, 2021

I've updated the base for this PR to the new release/9.11.0 branch, it is ready to merge

@mitchelsellers mitchelsellers merged commit 09f08ef into dnnsoftware:release/9.11.0 Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants