Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the Package Version to XmlMerge when updating AssemblyInstaller bindings. #4873

Merged

Conversation

dimarobert
Copy link
Contributor

Fixes #4872

Summary

Change to using the Package Version instead of the File Version for the XmlMerge that updates the assembly bindings in AssemblyInstaller.

@bdukes bdukes added this to the 9.10.3 milestone Oct 13, 2021
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mitchelsellers
Copy link
Contributor

@bdukes I just want to make sure - this only impacts the comments correct? Not the actual binding.

@bdukes
Copy link
Contributor

bdukes commented Oct 13, 2021

Good question. I've confirmed that the only usage of the Version property set by that constructor argument is in the comment header

string commentHeaderText = string.Format(
Localization.GetString("XMLMERGE_Upgrade", Localization.SharedResourceFile),
Environment.NewLine,
this.Sender,
this.Version,
DateTime.Now);

@bdukes bdukes merged commit 79e18b5 into dnnsoftware:develop Oct 13, 2021
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package version should be used in the Save message of AssemblyInstaller XmlMerge binding update.
4 participants