Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nuka-carousel reference #4891

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2021

Removes unused nuka-carousel dependency.

Bumps [nuka-carousel](https://github.com/kenwheeler/nuka-carousel) from 4.5.6 to 4.8.2.
- [Release notes](https://github.com/kenwheeler/nuka-carousel/releases)
- [Changelog](https://github.com/FormidableLabs/nuka-carousel/blob/main/CHANGELOG.md)
- [Commits](FormidableLabs/nuka-carousel@v4.5.6...v4.8.2)

---
updated-dependencies:
- dependency-name: nuka-carousel
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added javascript Pull requests that update Javascript code Type: Maintenance labels Nov 1, 2021
@bdukes
Copy link
Contributor

bdukes commented Nov 1, 2021

nuka-carousel does not appear to be used anywhere, do we want to go ahead and remove it?

@mitchelsellers
Copy link
Contributor

YES!!!!!

@bdukes
Copy link
Contributor

bdukes commented Nov 2, 2021

Okay, I've updated this PR to remove it.

@bdukes bdukes changed the title Bump nuka-carousel from 4.5.6 to 4.8.2 Remove nuka-carousel reference Nov 2, 2021
@bdukes bdukes added this to the 9.10.3 milestone Nov 2, 2021
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valadas valadas merged commit c7094dd into develop Nov 2, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nuka-carousel-4.8.2 branch November 2, 2021 18:06
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants