-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SSL approach #4892
Improve SSL approach #4892
Conversation
…nt this in the PB security settings panel.
I've updated the base for this PR to the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and great behavior changes I think this will help. I did make one suggestion for naming/consistency.
/// <summary> | ||
/// Gets or sets the total nr of (non-deleted) tabs of the portal. | ||
/// </summary> | ||
public int NrTabs { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this field, and the following 2 should be either renamed to "NumberOfTabs" or "TabCount" to provide clear, non-shorted variable names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the mentioned suggestions and a double-check from @bdukes on potential breaking changes, this looks great to me. Nice one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you sir.
I'm late to the party, but I have two questions...
|
This PR aims to do the following:
The overarching goal is to improve security. Users can get lost in the various settings and mistakes are easily made.
Implementation
The changes are as follows:
Resolves #4942