Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Upload interfaces #4909

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Standardize Upload interfaces #4909

merged 1 commit into from
Nov 14, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Nov 9, 2021

Summary

Standardize file upload implementations to all use either upload file or select file workflows.

Before

Icon upload on Pages
User profile upload

After

Icon upload on Pages
User profile upload

@bdukes bdukes added this to the 9.11.0 milestone Nov 9, 2021
mitchelsellers
mitchelsellers approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! I am going to do a bit more testing on the final build once it completes to validate a few usage scenarios.

david-poindexter
david-poindexter approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thank you @bdukes

valadas
valadas approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks geat! Thanks!

@bdukes bdukes changed the base branch from develop to release/9.11.0 November 12, 2021 20:54
@bdukes
Copy link
Contributor Author

bdukes commented Nov 12, 2021

I've updated the base for this PR to the new release/9.11.0 branch, it is ready to merge

@mitchelsellers mitchelsellers merged commit 22de743 into dnnsoftware:release/9.11.0 Nov 14, 2021
@mitchelsellers mitchelsellers deleted the remove-upload-from-url branch November 14, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donker donker donker approved these changes

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Area: AE > Dnn.React.Common Type: Enhancement
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bdukes @donker @david-poindexter @mitchelsellers @valadas