Adjust release merge workflow #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
Dec 1, 2021
|
This is a release management task, as per our policy, we are self-approving it. |
|
@valadas @mitchelsellers it looks like there's still a permissions issue (I guess on my test repo opening a PR for my own repo didn't trigger this scenario). I think we may need to add a secret with an access token that has permission to create branches, and use that instead of |
|
I don't know, I have done it with GITHUB_TOKEN for the updating of versions one... |
|
I saw someone saying that GitHub won't allow editing workflow files with |
|
I guess it just successfully created #4934, so maybe it has to do with who created the PR it's reacting to? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow triggered by the merge/rebase of #4925 failed, presumably because it was accessing the
merge_commit_shabut the PR was closed via rebase. I've updated the workflow to just usesha, which still points to the rebased commit, and tested on my repo.