Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge expired auth cookies #5001

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Conversation

donker
Copy link
Contributor

@donker donker commented Feb 1, 2022

Summary

Add a scheduled task to purge AuthCookies from the DB that have expired.

Fixes #4982

@donker donker added this to the 9.11.0 milestone Feb 1, 2022
@donker donker changed the base branch from develop to release/9.11.0 February 1, 2022 16:57
Copy link
Contributor

@sleupold sleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sproc: Using TOP should include an "Order By" statement.

@donker
Copy link
Contributor Author

donker commented Feb 1, 2022

sproc: Using TOP should include an "Order By" statement.

Not for DELETE TOP.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seen a ton of delete examples that don't have an OrderBy

…9.11.00.SqlDataProvider

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@sleupold
Copy link
Contributor

sleupold commented Feb 2, 2022

for large tables, it might be useful to add an unique index on "ExpiresOn, CookieID" column and use "ORDER BY ExpiresOn DESC"

@valadas valadas merged commit c44f3f6 into dnnsoftware:release/9.11.0 Feb 16, 2022
@donker donker deleted the purgeauthcookies branch July 24, 2022 08:27
@WillStrohl
Copy link
Contributor

Nice one! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge expired AuthCookies
6 participants