Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the localization for partial MVC view requests. #5004

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

dimarobert
Copy link
Contributor

@dimarobert dimarobert commented Feb 4, 2022

Fixes #5003

Summary

Sets up the thread culture info for partially rendered MVC views, similar to how it is done for normal page requests (WebForms and MVC) and WebAPI requests.

@bdukes bdukes added this to the 9.10.3 milestone Feb 4, 2022
@bdukes
Copy link
Contributor

bdukes commented Feb 4, 2022

It looks to me like this failed because it ran on an agent with windows 2022 instead of 2019.

D:\a\1\s\Dnn.AdminExperience\Dnn.PersonaBar.Extensions\Dnn.PersonaBar.Extensions.csproj(755,3): error MSB4019: The imported project "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v11.0\WebApplications\Microsoft.WebApplication.targets" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk. [D:\a\1\s\Dnn.AdminExperience\Dnn.PersonaBar.Extensions\Dnn.PersonaBar.Extensions.csproj]

The line it's pointing to is

<Import Project="$(VSToolsPath)\WebApplications\Microsoft.WebApplication.targets" Condition="'$(VSToolsPath)' != ''" />

This is an error during the clean target, not even the rebuild target.

One solution is to revert to windows-2019 instead of using windows-latest. We can also look at upgrading Cake to 2.x, which is supposed to know more about the newer version of Visual Studio (which, I assume, is pre-installed on the agent).

@valadas
Copy link
Contributor

valadas commented Feb 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit c9ef23e into dnnsoftware:develop Feb 16, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurrentCulture/CurrentUICulture are not set when rendering a partial MVC view.
3 participants