Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonIgnore Attribute #5006

Merged

Conversation

mtrutledge
Copy link
Contributor

@mtrutledge mtrutledge commented Feb 8, 2022

Fixes #5005

Summary

Anywhere there was an XmlIgnore attribute we have added a JsonIgnore attribute from the Newtonsoft.Json library. This will help to ensure serializing to Json is mirroring the XML serialization objects.

@bdukes bdukes added this to the 9.11.0 milestone Feb 8, 2022
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valadas
Copy link
Contributor

valadas commented Feb 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@valadas
Copy link
Contributor

valadas commented Feb 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrutledge
Copy link
Contributor Author

YAY passing build.

@valadas valadas merged commit 5769549 into dnnsoftware:release/9.11.0 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants