Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GTM to follow Google best practices #5023

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

david-poindexter
Copy link
Contributor

Resolves #5022

The script for the HEAD needs to be as high up as possible according to https://developers.google.com/tag-platform/tag-manager/web
@david-poindexter david-poindexter added this to the 9.10.3 milestone Feb 23, 2022
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@mitchelsellers mitchelsellers merged commit 16f3c5e into dnnsoftware:develop Feb 23, 2022
@david-poindexter david-poindexter deleted the gtm-config-fix branch February 23, 2022 05:41
@bdukes
Copy link
Contributor

bdukes commented Feb 23, 2022

We've seen issues in the past where injecting into the top of a container invalidates all of the ViewState in the controls that come later. I think that was resolved at some point by hooking up to a different event in the page lifecycle, and it probably doesn't have much application in the <head> (we saw it previously when InjectTop was True for the Body or Form control), but it's worth being aware to keep an eye out for issues.

@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct HEAD script for Google Tag Manager config
4 participants