Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versions of dependencies in Nuget spec files #5028

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

donker
Copy link
Contributor

@donker donker commented Feb 27, 2022

Since version 9.10.0 DNN moved up the dependencies on Microsoft's libraries. This should be reflected in the Nuspec file or else your module will not build. This also means that 9.10.0, 9.10.1 and 9.10.2 nuget packages for DNN will not work to build MVC style modules.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this. I’m also going to look and see if this can be managed automatically like it is of other project types for the future.

@mitchelsellers mitchelsellers merged commit dc05dbb into dnnsoftware:develop Feb 28, 2022
@donker donker deleted the fixnuget branch March 12, 2022 10:22
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants