Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to report issues when clean fails #5034

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix failure to report issues when clean fails #5034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions Build/Tasks/Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
namespace DotNetNuke.Build.Tasks
{
using System;
using System.Collections.Generic;
using System.Linq;

using Cake.Common.Build;
using Cake.Common.Build.AzurePipelines.Data;
Expand Down Expand Up @@ -41,18 +41,12 @@ public override void Run(Context context)
}
finally
{
var issues = context.ReadIssues(
new List<IIssueProvider>
{
new MsBuildIssuesProvider(
context.Log,
new MsBuildIssuesSettings(cleanLog, context.MsBuildBinaryLogFileFormat())),
new MsBuildIssuesProvider(
context.Log,
new MsBuildIssuesSettings(buildLog, context.MsBuildBinaryLogFileFormat())),
},
context.Directory("."));

var issueProviders =
from logFilePath in new[] { cleanLog, buildLog, }
where context.FileExists(logFilePath)
let settings = new MsBuildIssuesSettings(cleanLog, context.MsBuildBinaryLogFileFormat())
select new MsBuildIssuesProvider(context.Log, settings);
var issues = context.ReadIssues(issueProviders, context.Directory("."));
foreach (var issue in issues)
{
var messageData = new AzurePipelinesMessageData
Expand Down