Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error getting host tab URL #5052

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix error getting host tab URL #5052

merged 1 commit into from
Mar 29, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Mar 17, 2022

Closes #5051

This PR fixes two related issues.

First, in module settings, when getting the alias for a page, use the host portal ID if it's a host tab.

Second, in the advanced friendly URL provider, make sure that PortalAlias isn't null before trying to read its HttpAlias.

@bdukes bdukes added this to the 9.10.3 milestone Mar 17, 2022
valadas
valadas approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant

@valadas valadas merged commit de7fd31 into dnnsoftware:develop Mar 29, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@valadas valadas valadas approved these changes

@aspelt aspelt aspelt approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.11.0
Development

Successfully merging this pull request may close these issues.

Error viewing module settings when module is shared on a host page
4 participants
@bdukes @david-poindexter @valadas @aspelt