Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows localization of search categories #5053

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

Andy9999
Copy link
Contributor

@Andy9999 Andy9999 commented Mar 20, 2022

Fixes #5049.

Caching search results needs to include the current culture in the key.

Summary

Fix for issue 5049.

Caching search results needs to include the current culture in the key.
Fixed unit test to use the new key including culture.
@valadas
Copy link
Contributor

valadas commented Mar 20, 2022

@Andy9999 There is a comment trick that associates a PR with an Issue in a way that the issue is automatically closed when the PR is merged. You can read more about it here https://docs.devart.com/studio-for-sql-server/source-controlling-databases/associating-commits-with-github-issues.html
I edited the first line of your comment accordingly.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see aproblem with this.

@Andy9999
Copy link
Contributor Author

@Andy9999 There is a comment trick that associates a PR with an Issue in a way that the issue is automatically closed when the PR is merged. You can read more about it here https://docs.devart.com/studio-for-sql-server/source-controlling-databases/associating-commits-with-github-issues.html I edited the first line of your comment accordingly.

Thank you! Will try that trick with the other 2 issues next weekend. :)

@valadas valadas added this to the 9.10.3 milestone Mar 20, 2022
@valadas valadas changed the title Update InternalSearchControllerImpl.cs Allows localization of search categories Mar 20, 2022
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@valadas valadas merged commit e658f1f into dnnsoftware:develop Mar 21, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization of DNN Search Categories
3 participants